audio: drc: clean up "inline" usage in .c#9948
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Apr 4, 2025
Merged
Conversation
"inline" without "static" suggests that the function is inlined when called in the same file and will also be compiled out-of-line to be called from other files. This wasn't intended in drc_math_hifi3.c nor in drc_math_generic.c because in most cases those functions are never even called in those files. Remove "inline." Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
CI: an unclear (to me) tool-build failure https://sof-ci.01.org/sofpr/PR9948/build11987/build/index.html. Actually I'm rather sure that this PR shouldn't cause any build- or run-time regressions, but I'll relaunch SOF CI for the protocol |
Collaborator
Author
|
SOFCI TEST |
kv2019i
approved these changes
Apr 4, 2025
singalsu
approved these changes
Apr 4, 2025
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
There's no measurable impact to MCPS in HiFi3 build, same 31.3 with before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"inline" without "static" suggests that the function is inlined when called in the same file and will also be compiled out-of-line to be called from other files. This wasn't intended in drc_math_hifi3.c nor in drc_math_generic.c because in most cases those functions are never even called in those files. Remove "inline."